refactor: use macros for WordCount#789
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Jul 7, 2025
Merged
Conversation
WordCountWordCount
ItoroD
reviewed
Jun 30, 2025
| use bdk_wallet::keys::bip39::WordCount; | ||
| use bdk_wallet::KeychainKind; | ||
|
|
||
| type WordCount = bdk_wallet::keys::bip39::WordCount; |
Collaborator
There was a problem hiding this comment.
This is good. One small question is why is this put in lib.rs and not type.rs?
ItoroD
approved these changes
Jun 30, 2025
Collaborator
Author
|
had to rebase, will merge this first when ci passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate
WordCountto use proc macroNotes to the reviewers
Unfortunately
lib.rsrequired type alias thing, but this is the same pattern used for KeychainKind intypes.rs. The type alias is necessary because we can't have both an import and an enum definition with the same name in the same scope.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: